Pass Vec<Segment> as &[Segment] #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See stratis-storage/stratisd#574 for usage. |
7d6b0ba to
b6d224d
Compare
Closed
trgill
approved these changes
Sep 20, 2017
These are really just representations of data, not things that should be claimed. The segments are all cloneable. Also, it should make error-chain easier, since the segments no longer need to be moved in the same way. Signed-off-by: mulhern <amulhern@redhat.com>
b6d224d to
f08beb2
Compare
|
rebased. |
|
@agrover review? |
|
Blocks #163. |
|
👍 , merging as last reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are really just representations of data, not things that should be
claimed. The segments are all cloneable.
Also, it should make error-chain easier, since the segments no longer
need to be moved in the same way.
Signed-off-by: mulhern amulhern@redhat.com