Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disperse constants that are not broadly shared into appropriate modules #165

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Disperse constants that are not broadly shared into appropriate modules #165

merged 1 commit into from
Sep 14, 2017

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Sep 12, 2017 •
edited
Loading

Resolves: #72.

@mulkieran
Copy link
Member Author

Note: currently IEC is defined in both devicemapper-rs and stratisd. We should eliminate it from one or the other, probably from stratisd.

@mulkieran mulkieran changed the title Export public constants explicitly Disperse constants that are not broadly shared into appropriate modules Sep 12, 2017
@mulkieran
Disperse most of the constants defined in consts.rs into other modules
d32bc71 
Many are explicitly associated with one module, and might as well be
localized there. In C, we couldn't do this because we couldn't have
constants in mutually dependent modules, but in Rust there is no such
problem.

Some constants are associated with one module; these are private, for
better encapsulation.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

rebased.

@mulkieran mulkieran requested review from agrover and trgill September 13, 2017 11:55
@mulkieran
Copy link
Member Author

@agrover @trgill review?

@mulkieran
Copy link
Member Author

clippy has caught up w/ new release. So, this should succeed now.

@mulkieran
Copy link
Member Author

@agrover review?

@mulkieran mulkieran mentioned this pull request Sep 14, 2017
Closed
@agrover agrover merged commit 957c065 into stratis-storage:master Sep 14, 2017
@mulkieran mulkieran deleted the master-consts branch September 14, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trgill trgill trgill approved these changes

@agrover agrover Awaiting requested review from agrover

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mulkieran @trgill @agrover