Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Node 14 -> 20 #1761

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Jun 26, 2023

What does it do?

Remove Node 14 as a supported version, add Node 20.

Replace examples with Node 20 so we don't have to jump them again soon :)

Why is it needed?

Strapi supported versions are moving to Node 16, 18, and 20

Related issue(s)/PR(s)

Wait to merge until Node 20 PR is released. Hoping for 4.11.4 but could be pushed to later if it doesn't get QAd and merged in the next couple days.

@innerdvations innerdvations added the flag: merge pending release Pending Strapi Release label Jun 26, 2023
@innerdvations innerdvations added this to the 4.12.0/4.13.0-beta.1 milestone Jun 26, 2023
@innerdvations innerdvations requested a review from pwizla June 26, 2023 16:09
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 8:58am

@pwizla pwizla self-assigned this Jul 3, 2023
@pwizla pwizla modified the milestones: 4.11.4, 4.11.5 Jul 5, 2023
@pwizla pwizla modified the milestones: 4.11.5, 4.12.0/4.13.0-beta.1 Jul 12, 2023
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: chore labels Jul 19, 2023
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ben. Approved, just waiting for the corresponding strapi/strapi PR to be merged before merging this one. Feel free to ping me whenever it's ready :)

@pwizla pwizla added the internal PRs created by the Strapi core team label Jul 19, 2023
@innerdvations
Copy link
Collaborator Author

@pwizla This was merged yesterday after the release lock, which means it's NOT coming out tomorrow (4.12.0), but will be in next week's release (4.12.1?)

@pwizla pwizla modified the milestones: 4.12.0, 4.12.1 Jul 25, 2023
@meganelacheny meganelacheny merged commit 4af7b5b into main Aug 2, 2023
@meganelacheny meganelacheny deleted the chore/node-14-to-20 branch August 2, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: merge pending release Pending Strapi Release internal PRs created by the Strapi core team pr: chore source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants