Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix: middleware panic upon receiving amount that is not int64 #78

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: middleware panic upon receiving amount that is not int64 #78

merged 1 commit into from
May 19, 2023

Conversation

xlab
Copy link
Contributor

@xlab xlab commented May 8, 2023 •
edited
Loading

Added a check that doesn't attempt to do SetGaugeWithLabels if amount is not convertible to Int64. Doesn't raise a panic in case when uint256 numbers used for amount.

Added a new unit test:

--- FAIL: TestOnRecvPacket_ForwardAmountInt256 (0.00s)
panic: Int64() out of bound [recovered]
	panic: Int64() out of bound [recovered]
	panic: Int64() out of bound

Resolves #77

@jonathanpberger jonathanpberger mentioned this pull request May 8, 2023
Closed
agouin
agouin approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@agouin agouin merged commit 0716548 into strangelove-ventures:main May 19, 2023
@xlab xlab deleted the f/fix-uint256-overflow branch May 21, 2023 15:21
boojamya pushed a commit that referenced this pull request May 23, 2023
@xlab @boojamya
fix: middleware panic upon receiving amount that is not int64; added …
57a354b 
…test (#78)

resolves #77
boojamya pushed a commit that referenced this pull request May 23, 2023
@xlab @boojamya
fix: middleware panic upon receiving amount that is not int64; added …
e3b8db2 
…test (#78)

resolves #77
@boojamya boojamya mentioned this pull request May 23, 2023
Merged
boojamya pushed a commit that referenced this pull request May 23, 2023
@xlab @boojamya
fix: middleware panic upon receiving amount that is not int64; added …
f6ef0a5 
…test (#78)

resolves #77
@boojamya boojamya mentioned this pull request May 23, 2023
Merged
boojamya pushed a commit that referenced this pull request May 23, 2023
@xlab @boojamya
fix: middleware panic upon receiving amount that is not int64; added …
ac5661e 
…test (#78)

resolves #77
@boojamya boojamya mentioned this pull request May 23, 2023
Merged
boojamya pushed a commit that referenced this pull request May 23, 2023
@xlab @boojamya
fix: middleware panic upon receiving amount that is not int64; added …
da68406 
…test (#78)

resolves #77
@boojamya boojamya mentioned this pull request May 23, 2023
Merged
jackzampolin pushed a commit that referenced this pull request May 23, 2023
@boojamya @agouin @xlab
Merge PR #81: Backport #81, #78 into v3
84f3aa0 
* Fix same bool being used for all 3 (#81)

* fix: middleware panic upon receiving amount that is not int64; added test (#78)

resolves #77

* fix test

* remove unused make command

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>
Co-authored-by: Max Kupriianov <max@kc.vc>
jackzampolin pushed a commit that referenced this pull request May 23, 2023
@boojamya @agouin @xlab
Merge PR #84: Backports #78, #80, #81 into v4
17bd5de 
* Fix same bool being used for all 3 (#81)

* fix: middleware panic upon receiving amount that is not int64; added test (#78)

resolves #77

* Fix: Allows timeout field to accept both uint64 and string durations (#80)

* timeout accetps both string and time.duration

* feedback

* handle invalid unmarshalls

* Update router/ibc_middleware.go

Co-authored-by: Andrew Gouin <andrew@gouin.io>

* add test case for empty valid json

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>

* fix tests

* remove unused protos

* regen-protos

* fix lint

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>
Co-authored-by: Max Kupriianov <max@kc.vc>
jackzampolin pushed a commit that referenced this pull request May 23, 2023
@boojamya @agouin @xlab
Merge PR #85: Backports #78, #80, #81 into v5
86f045c 
* Fix same bool being used for all 3 (#81)

* fix: middleware panic upon receiving amount that is not int64; added test (#78)

resolves #77

* Fix: Allows timeout field to accept both uint64 and string durations (#80)

* timeout accetps both string and time.duration

* feedback

* handle invalid unmarshalls

* Update router/ibc_middleware.go

Co-authored-by: Andrew Gouin <andrew@gouin.io>

* add test case for empty valid json

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>

* fix for ibc-go version

* re gen protos

* remove unused make test command

* fix lint

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>
Co-authored-by: Max Kupriianov <max@kc.vc>
jackzampolin pushed a commit that referenced this pull request May 23, 2023
@boojamya @agouin @xlab
Merge #86: Backports #78, #80, #81 into v6
c0b7072 
* Fix same bool being used for all 3 (#81)

* fix: middleware panic upon receiving amount that is not int64; added test (#78)

resolves #77

* Fix: Allows timeout field to accept both uint64 and string durations (#80)

* timeout accetps both string and time.duration

* feedback

* handle invalid unmarshalls

* Update router/ibc_middleware.go

Co-authored-by: Andrew Gouin <andrew@gouin.io>

* add test case for empty valid json

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>

* make compliant with ibc-go version and fix lint

* remove unused make test command

* regen protos

* add lint check to CI

---------

Co-authored-by: Andrew Gouin <andrew@gouin.io>
Co-authored-by: Max Kupriianov <max@kc.vc>
@devon-chain devon-chain mentioned this pull request Jul 27, 2023
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

@agouin agouin agouin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Middleware panics when transferring tokens with 10^18 denom
3 participants
@xlab @agouin @mtsitrin