-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Findthrust.cmake parse error #407
Labels
Comments
Thanks for the report. This indeed looks like a bug in |
HWZen
added a commit
to HWZen/stdgpu
that referenced
this issue
Mar 13, 2024
Fix bug stotko#407: The original regular replacement does not consider the possibility that THRUST_VERSION may be followed by comments.
HWZen
added a commit
to HWZen/stdgpu
that referenced
this issue
Mar 13, 2024
Fix bug stotko#407: The original regular replacement does not consider the possibility that THRUST_VERSION may be followed by comments.
stotko
pushed a commit
that referenced
this issue
Mar 13, 2024
Fix bug #407: The original regular replacement does not consider the possibility that THRUST_VERSION may be followed by comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Cannot config project because Findthrust.cmake@15 cannot find the thrust properly.
Look at this code:
It does not take into account that #define THRUST_VERSION may be followed by comments.
Unfortunately, cuda 12.4's thrust/version.h has a comment after THRUST_VERSION
So
${THRUST_VERSION_STRING}
in cmake was parsed to200301 // macro expansion with ## requires this to be a single value
and led to subsequent errors in judgment.If you think what I'm saying makes sense, I'll be happy to fix it.
System (please complete the following information):
The text was updated successfully, but these errors were encountered: