-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and Revert Duplicate License Terms #75
Detect and Revert Duplicate License Terms #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, are there any other place you need to check the return value of the .add function, which may be causing bugs?
The return value is for indicating whether the item has already exist in the Set. As this is the only one function to register derivative relationship between child Ip and parent IP need to check duplicate. no other place need this check. |
* Duplicate licenses revert
This PR detects duplicate license terms when registering derivative and revert operations.
Closes #41