Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON formatting issue and typos #385

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Himess
Copy link

@Himess Himess commented Jan 23, 2025

## Description
This PR resolves a JSON formatting issue and addresses multiple typos across the codebase. Below is a detailed breakdown of the changes made:

1. GroupNFT.sol
Issue:
The 'description' field in the 'tokenURI' function contained incorrect JSON formatting, which could lead to invalid JSON.
'"description": IPAsset Group",' to '"description": "IPAsset Group",'

2. IPAccountImpl.sol
Issues:
1-The word 'bethe' was a typo in a comment.
2-A missing word ('for') in a comment made it unclear.
'bethe' to 'be the'
'/// @dev Updates the IP Account's state all execute transactions.' to '/// @dev Updates the IP Account's state for all executed transactions.'

3. StorageLayoutCheck.s.sol
Issue:
'string.concat' was unnecessarily used for a single string in the 'inputBuilder.'

'inputBuilder[i++] = string.concat("@openzeppelin/upgrades-core");' to 'inputBuilder[i++] = "@openzeppelin/upgrades-core";'


Why These Changes Were Made
-To ensure valid JSON formatting for GroupNFT.
-To fix typos and improve clarity in comments for better readability.
-To remove unnecessary code and improve efficiency in StorageLayoutCheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant