-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 0xSplits with new ERC20 Royalty Vault #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this direction. Is ERC20Snapshot a standard token?
9a2c6e1
to
06cde7a
Compare
ERC20Snapshot is in OpenZeppelin's v4 codebase but was deprecated in v5. |
Have we looked at Votes.sol in OZ v5, which is suppose to replace ERC20Snapshot (and focus more on voting)? See this comment
|
Yes, we checked. ERC20Snapshot seems more of a fit to our use case. |
contracts/interfaces/modules/royalty/policies/IIpRoyaltyVault.sol
Outdated
Show resolved
Hide resolved
contracts/interfaces/modules/royalty/policies/IIpRoyaltyVault.sol
Outdated
Show resolved
Hide resolved
contracts/interfaces/modules/royalty/policies/IIpRoyaltyVault.sol
Outdated
Show resolved
Hide resolved
contracts/interfaces/modules/royalty/policies/IIpRoyaltyVault.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make another batch of review, still need more clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve it for the release, a few minor clarifications are still needed, can communicate offline.
* add the p1 tests * add tests for permission and register derivative * Deploy oov3 sandbox (storyprotocol#31) * update workflow * update workflow * test * test * test * test * test * update workflow * add dispute tests * Update dispute.test.ts * Update hardhat_e2e.yml * Update dispute.test.ts --------- Co-authored-by: Jacqueline Zhang <131138188+jacqueline-57b@users.noreply.github.com> Co-authored-by: Jacqueline Zhang <jacqueline@57blocks.com>
* add the p1 tests * add tests for permission and register derivative * Deploy oov3 sandbox (storyprotocol#31) * update workflow * update workflow * test * test * test * test * test * update workflow * add dispute tests * Update dispute.test.ts * Update hardhat_e2e.yml * Update dispute.test.ts --------- Co-authored-by: Jacqueline Zhang <131138188+jacqueline-57b@users.noreply.github.com> Co-authored-by: Jacqueline Zhang <jacqueline@57blocks.com>
* add the p1 tests * add tests for permission and register derivative * Deploy oov3 sandbox (#31) * update workflow * update workflow * test * test * test * test * test * update workflow * add dispute tests * Update dispute.test.ts * Update hardhat_e2e.yml * Update dispute.test.ts --------- Co-authored-by: Jacqueline Zhang <131138188+jacqueline-57b@users.noreply.github.com> Co-authored-by: Jacqueline Zhang <jacqueline@57blocks.com>
* add the p1 tests * add tests for permission and register derivative * Deploy oov3 sandbox (storyprotocol#31) * update workflow * update workflow * test * test * test * test * test * update workflow * add dispute tests * Update dispute.test.ts * Update hardhat_e2e.yml * Update dispute.test.ts --------- Co-authored-by: Jacqueline Zhang <131138188+jacqueline-57b@users.noreply.github.com> Co-authored-by: Jacqueline Zhang <jacqueline@57blocks.com>
This pr introduces new logic that replaces 0xSplits tooling with a new Ip Pool:
In the Ip Pool contract: