Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add royalty fee switch #243

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add royalty fee switch #243

merged 3 commits into from
Sep 17, 2024

Conversation

Spablob
Copy link

@Spablob Spablob commented Sep 13, 2024

Description

Adds the possibility of setting a % fee on royalties paid through the protocol.

@Spablob Spablob marked this pull request as ready for review September 13, 2024 21:05
kingster-will
kingster-will reviewed Sep 16, 2024
View reviewed changes
Copy link

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Spablob Spablob merged commit 946203f into storyprotocol:main Sep 17, 2024
2 checks passed
@kingster-will kingster-will mentioned this pull request Oct 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingster-will kingster-will kingster-will approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spablob @kingster-will