forked from storyprotocol/protocol-core
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifying IP Registration and Metadata Management in Story Protocol #17
Merged
LeoHChen
merged 3 commits into
storyprotocol:main
from
kingster-will:v1/cleanup-registration
Mar 27, 2024
Merged
Simplifying IP Registration and Metadata Management in Story Protocol #17
LeoHChen
merged 3 commits into
storyprotocol:main
from
kingster-will:v1/cleanup-registration
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this one depending on the new storage ? |
8fc4e78
to
47388c4
Compare
The PR doesn’t depend on the new storage; this PR just cleans up obsolete code since we introduced permissionless IP registration and metadata modules with other PRs. However, permissionless IP Registration and metadata modules depend on the new storage. |
LeoHChen
approved these changes
Mar 25, 2024
jdubpark
reviewed
Mar 27, 2024
jdubpark
approved these changes
Mar 27, 2024
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 18, 2025
…elist Add blacklist arbitration policy restriction
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 31, 2025
kingster-will
pushed a commit
that referenced
this pull request
Jan 31, 2025
irfand29
pushed a commit
to irfand29/protocol-core-v1
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant changes aimed at simplifying the IP registration process and the handling of metadata within the protocol. By focusing on permissionless IP registration and removing complex metadata components, we've made the system more accessible and reduced the overall complexity of the codebase.
Key Changes:
Cleanup of Permissioned IP Registration Code Path
Simplification of Metadata Handling
These changes collectively enhance the protocol by making IP registration more accessible and simplifying the management of metadata. By removing unnecessary components and focusing on a streamlined approach, we've made the system more efficient and easier to maintain.