Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration Time for Child IPs Not Exceed Parent IP #129

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

kingster-will
Copy link

Description

This PR addresses the issue where the expiration time of a Child IP could exceed the expiration time of its Parent IP, which contradicts the intended inheritance of expiration constraints from parent to derivative IPs.

Key Changes

  • Modified the derivative registration logic to ensure that the expiration time of the Child IP is either equal to or earlier than that of the Parent IP.

Test Plan

  • Updated tests to include scenarios where the Parent IP has a shorter expiration time than the license terms to which a Child IP registers.

Related Issue

Closes #128

@LeoHChen
Copy link

Can you clarify it with @jzhao23 on this issue? Is it an expected biz case?

Copy link

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, some code duplication, similar logic appeared 3 times.

@kingster-will
Copy link
Author

Can you clarify it with @jzhao23 on this issue? Is it an expected biz case?

Yes, I confirmed with @jzhao23 that this is expected behavior from a product perspective that the Child IP should not be active after the Parent IP expires.

@LeoHChen LeoHChen merged commit 96ebc7c into storyprotocol:main Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child IP's Expiration Time Should be earlier than Parent IP's Expiration Time
4 participants