forked from storyprotocol/protocol-core
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiration Time for Child IPs Not Exceed Parent IP #129
Merged
LeoHChen
merged 4 commits into
storyprotocol:main
from
kingster-will:v11/child-inherit-expire
Apr 22, 2024
Merged
Expiration Time for Child IPs Not Exceed Parent IP #129
LeoHChen
merged 4 commits into
storyprotocol:main
from
kingster-will:v11/child-inherit-expire
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spablob
reviewed
Apr 19, 2024
Spablob
reviewed
Apr 19, 2024
Spablob
reviewed
Apr 19, 2024
Spablob
reviewed
Apr 19, 2024
Can you clarify it with @jzhao23 on this issue? Is it an expected biz case? |
jdubpark
approved these changes
Apr 21, 2024
LeoHChen
reviewed
Apr 21, 2024
LeoHChen
reviewed
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general, some code duplication, similar logic appeared 3 times.
LeoHChen
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where the expiration time of a Child IP could exceed the expiration time of its Parent IP, which contradicts the intended inheritance of expiration constraints from parent to derivative IPs.
Key Changes
Test Plan
Related Issue
Closes #128