Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify royalty logic #1

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Simplify royalty logic #1

merged 3 commits into from
Feb 28, 2024

Conversation

Spablob
Copy link

@Spablob Spablob commented Feb 28, 2024

This pr makes 3 adjustments to the LAP royalty policy:

  • Does a minor fix the event PolicyInitialized
  • Changes the receiver of the RNFTs present the ancestors vault to being the IPAccount (vs the IP Pool) to significantly simplify the royalty claiming process
  • Removes ETH claiming from the codebase to simplify the code given it is not supported for payment and therefore was not being used

@Spablob Spablob marked this pull request as ready for review February 28, 2024 02:18
LeoHChen
LeoHChen reviewed Feb 28, 2024
View reviewed changes
Copy link

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a github issue to SDK team about this change that will impact SDK/API

@Spablob Spablob changed the title Adjust royalty logic Simplify royalty logic Feb 28, 2024
@LeoHChen LeoHChen merged commit a9f5a2a into storyprotocol:main Feb 28, 2024
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Feb 28, 2024
@Spablob @kingster-will
Simplify royalty logic (#1)
d1e68a2 
* Fix PolicyInitialized event

* remove withdrawETH for code simplification and clarity

* change RNFT recipient to IPAccount instead of IP Pool + remove withdrawETH from ancestors vault
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Mar 19, 2024
@Spablob @kingster-will
Simplify royalty logic (#1)
b865967 
* Fix PolicyInitialized event

* remove withdrawETH for code simplification and clarity

* change RNFT recipient to IPAccount instead of IP Pool + remove withdrawETH from ancestors vault
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Aug 9, 2024
@kingster-will
Integration of Protocol Contracts with Precompiled "IP Graph" Contrac…
6789db7 
…ts (#1)

* Integrate with IPGraph

* Integrate with IPGraph - Adjustments (#1)

* fix to allow high gas tests on github actions

* increase gas limit

* remove coverage test (not used in main repo)

(cherry picked from commit aa2581c652a1ad4108293f49e3fa65a9ed93e6eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoHChen LeoHChen LeoHChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spablob @LeoHChen