-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move License Template compatibility check to individual LicenseTemplates #80
Comments
I think for this release we are safer without this feature. We would have to be able to have inter-template compatibility checks, with common values that mean the same for every template. I think the minimum variables that could be reused across templates and help reduce significant compatibility issues are:
An alternative is to allow templates to say if they are compatible with others, but that puts a lot of trust on the templates, especially if we want too open template registration. One template would have to trust the other template did not alter the Licensing terms after claiming compatibility, potentially rugging the user. In beta, the solution was storing We would need to find a way of doing this without complicating the DX with encoding, or doing very simple encoding. |
* fix 3 failures 1. Shall not add IP to group if IP does not share the same licensing terms as the group 2. Dispute - Set tags to the derivative IP assets if the parent infringed 3. Dispute - Set tags to the derivative IP assets if the parent has not infringed
* fix 3 failures 1. Shall not add IP to group if IP does not share the same licensing terms as the group 2. Dispute - Set tags to the derivative IP assets if the parent infringed 3. Dispute - Set tags to the derivative IP assets if the parent has not infringed
* fix 3 failures 1. Shall not add IP to group if IP does not share the same licensing terms as the group 2. Dispute - Set tags to the derivative IP assets if the parent infringed 3. Dispute - Set tags to the derivative IP assets if the parent has not infringed
Currently, there's a global restriction in allowing only one license template per IP.
For example, if IP attaches PIL licenses, it can't attach licenses from other templates.
protocol-core-v1/contracts/registries/LicenseRegistry.sol
Lines 209 to 211 in 5d91e7a
This restriction might be very restrictive for some license templates, such as when a user wants to attach MIT licenses and some other licenses from different license templates.
Hence, we should move this check to be within each license template.
The text was updated successfully, but these errors were encountered: