Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoroughly test the new License system #39

Closed
jdubpark opened this issue Apr 8, 2024 · 1 comment
Closed

Thoroughly test the new License system #39

jdubpark opened this issue Apr 8, 2024 · 1 comment
Assignees
@kingster-will
Labels
enhancement New feature or request high priority license
Milestone
v1 code freeze

Comments

@jdubpark
Copy link

jdubpark commented Apr 8, 2024 •
edited
Loading

PR #33 introduced the new licensing system, we need to cover all previous test cases and test more thoroughly on:

  • LicenseRegistry
  • LicensingModule
  • PILicenseTemplate
@jdubpark jdubpark added the enhancement New feature or request label Apr 8, 2024
@jdubpark jdubpark changed the title Test LicenseRegistry Thoroughly test the new License system Apr 9, 2024
@LeoHChen LeoHChen added this to the v1 code freeze milestone Apr 11, 2024
@jdubpark
Copy link
Author

@kingster-will mark as solved with relevant PRs

@kingster-will kingster-will mentioned this issue Apr 12, 2024
Merged
kingster-will pushed a commit to kingster-will/protocol-core-v1-dev that referenced this issue Jan 18, 2025
@sebsadface
Merge pull request storyprotocol#39 from piplabs/fix/unused-param
8c07435 
Remove Unused Local Variable in `LicensingModule`
kingster-will pushed a commit to kingster-will/protocol-core-v1-dev that referenced this issue Jan 31, 2025
@sebsadface @kingster-will
Remove Unused Local Variable in LicensingModule (storyprotocol#39)
c53e69f
kingster-will pushed a commit that referenced this issue Jan 31, 2025
@sebsadface @kingster-will
Remove Unused Local Variable in LicensingModule (#39)
ea0c226
irfand29 pushed a commit to irfand29/protocol-core-v1 that referenced this issue Feb 8, 2025
@sebsadface @irfand29
Remove Unused Local Variable in LicensingModule (storyprotocol#39)
99de66a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingster-will kingster-will

Labels
enhancement New feature or request high priority license
Projects
None yet
Milestone
v1 code freeze
Development

No branches or pull requests
3 participants
@LeoHChen @jdubpark @kingster-will