Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify difference between skipped and excluded tags #396

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Nov 17, 2023

It took me a while to realize what the difference is between skipped and excluded tags (#382 (comment)). This is an attempt to clarify the docs in the README.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6dc95f) 80.64% compared to head (49c428c) 80.64%.

❗ Current head 49c428c differs from pull request most recent head 77751c3. Consider uploading reports for the commit 77751c3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #396   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          12       12           
  Lines         217      217           
  Branches       56       56           
=======================================
  Hits          175      175           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you so much @IanVS !

@yannbf yannbf added the skip-release Preserve the current version when merged label Nov 17, 2023
@yannbf yannbf merged commit 7edc4f2 into next Nov 17, 2023
13 checks passed
@yannbf yannbf deleted the skip-tags branch November 17, 2023 13:44
Copy link

🚀 PR was released in v0.15.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants