Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup play function checks #37

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Cleanup play function checks #37

merged 2 commits into from
Feb 3, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 3, 2022 •
edited by github-actions bot
Loading

What I did

  • Removed the checks for hasPlayFn in the codebase
  • Made the error link always include addon interactions
  • Added stories-json test to CI
📦 Published PR as canary version: 0.0.2-canary.37.86a700a.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.2-canary.37.86a700a.0
# or 
yarn add @storybook/test-runner@0.0.2-canary.37.86a700a.0

Version

Published prerelease version: v0.0.2-next.5

Changelog

🐛 Bug Fix

⚠️ Pushed to next

📝 Documentation

  • docs(README): add section about jest #29 (@yannbf)

Authors: 2

@yannbf yannbf requested a review from shilman February 3, 2022 08:29
shilman
shilman approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 💯

@shilman shilman merged commit b1997ee into next Feb 3, 2022
@shilman shilman deleted the fix/cleanup-has-play-fn branch February 3, 2022 08:33
@shilman shilman added the feature request New feature or request label Feb 3, 2022
@github-actions github-actions bot mentioned this pull request Feb 3, 2022
Merged
@yannbf yannbf mentioned this pull request Feb 3, 2022
Closed
@github-actions github-actions bot mentioned this pull request Feb 3, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @shilman