-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accessibility on searchbar react-native #6819
feat: add accessibility on searchbar react-native #6819
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-wilau2-feat-add-accessibility-on-5bd0b6.storybook.now.sh |
Thanks, what does testID do? |
@ndelangen It will normally keep your tests safe from css or js changes: You can check in the very same file I modified, it was already present on list item elements: |
@shilman, any reason we don't merge it? It is a non breaking change that can help for users using e2e tests with storybook. |
@Gongreg We're in a feature freeze for shipping 5.1. Can merge non-bug changes if there's good reason, but otherwise this is a 5.2 feature |
Got it @shilman. This one definitely doesn't break anything and helps people using detox or other e2e test tools. IMO we could silently add it to 5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
Make it easier to navigate between stories with detox.
(When list of story get big it's easier to navigate using the filter searchbar)