Allow forced renders in @storybook/html #6190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5017
What I did
This PR adds the ability to setup an
html
object parameter to control whether force re-renders are allowed or not like this:This addresses a change introduced in #4822. I understand the rationale around it, but right now it is just preventing @storybook/html to re-render stories returning a DOM node, which looks much more like a bug than a feature on normal use cases.
How to test
I added a test story in
examples/html-kitchen-sink/stories/addon-knobs.stories.js
(Addons > Knobs > DOM
) and the relevant configuration toexamples/html-kitchen-sink/.storybook/config.js