Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use direct react dependency in core #3382

Merged
merged 1 commit into from
Apr 8, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

Issue: #3381

It's already done on master via #3327, just need to do the same for release branch

@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #3382 into release/3.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release/3.4   #3382   +/-   ##
===========================================
  Coverage         35.6%   35.6%           
===========================================
  Files              436     436           
  Lines             9546    9546           
  Branches           904     913    +9     
===========================================
  Hits              3399    3399           
+ Misses            5573    5550   -23     
- Partials           574     597   +23
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-100%) ⬇️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
addons/storyshots/src/react/renderShallowTree.js 57.14% <0%> (ø) ⬆️
addons/info/src/components/Story.js 88.03% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
lib/core/src/client/manager/index.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReviver.js 71.42% <0%> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00572fe...ba28e84. Read the comment docs.

@tmeasday tmeasday merged commit 6dd721f into release/3.4 Apr 8, 2018
@tmeasday tmeasday deleted the react-peer branch April 8, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants