Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.5.0-beta.11 #30260

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 14, 2025

This is an automated pull request that bumps the version from 8.5.0-beta.10 to 8.5.0-beta.11.
Once this pull request is merged, it will trigger a new release of version 8.5.0-beta.11.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Manager API: Fix infinite render-loop caused by useSharedState #30259
  • 🔧 Maintenance: CLI: Update a11y-test comment with experimental caveat #30258

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.5.0-beta.11

  • CLI: Update a11y-test comment with experimental caveat - #30258, thanks @shilman!
  • Manager API: Fix infinite render-loop caused by useSharedState - #30259, thanks @JReinhold!

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Jan 14, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.5.0-beta.10 branch from 19298cc to d83c397 Compare January 14, 2025 13:06
@valentinpalkovic valentinpalkovic added bug freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. and removed bug labels Jan 14, 2025
@valentinpalkovic valentinpalkovic self-assigned this Jan 14, 2025
Copy link

nx-cloud bot commented Jan 14, 2025

View your CI Pipeline Execution ↗ for commit d83c397.

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3s View ↗
nx affected -t check -c production --parallel=7 ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-14 13:15:47 UTC

@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: d83c397, ran on 14 January 2025 at 13:24:12 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-a11y

Before After Difference
Dependency count 59 59 0
Self size 410 KB 228 KB 🎉 -183 KB 🎉
Dependency size 13.46 MB 13.46 MB 🚨 +42 B 🚨
Bundle Size Analyzer Link Link

@storybook/addon-essentials

Before After Difference
Dependency count 36 36 0
Self size 17 KB 12 KB 🎉 -4 KB 🎉
Dependency size 13.83 MB 13.83 MB 🎉 -25 B 🎉
Bundle Size Analyzer Link Link

@storybook/addon-mdx-gfm

Before After Difference
Dependency count 69 69 0
Self size 4 KB 3 KB 🎉 -1 KB 🎉
Dependency size 2.41 MB 2.41 MB 🚨 +3 B 🚨
Bundle Size Analyzer Link Link

@storybook/experimental-addon-test

Before After Difference
Dependency count 60 60 0
Self size 974 KB 762 KB 🎉 -212 KB 🎉
Dependency size 14.15 MB 14.15 MB 🚨 +29 B 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 397 398 🚨 +1 🚨
Self size 496 KB 504 KB 🚨 +8 KB 🚨
Dependency size 75.51 MB 75.55 MB 🚨 +45 KB 🚨
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic merged commit 936c3e0 into next-release Jan 14, 2025
109 of 115 checks passed
@valentinpalkovic valentinpalkovic deleted the version-non-patch-from-8.5.0-beta.10 branch January 14, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants