Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use ink in CLI #30202

Draft
wants to merge 136 commits into
base: next
Choose a base branch
from
Draft

CLI: Use ink in CLI #30202

wants to merge 136 commits into from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 7, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-30202-sha-958e81ef. Try it out in a new sandbox by running npx storybook@0.0.0-pr-30202-sha-958e81ef sandbox or in an existing project with npx storybook@0.0.0-pr-30202-sha-958e81ef upgrade.

More information
Published version 0.0.0-pr-30202-sha-958e81ef
Triggered by @ndelangen
Repository storybookjs/storybook
Branch norbert/cli-with-ink
Commit 958e81ef
Datetime Thu Jan 23 07:40:11 UTC 2025 (1737618011)
Workflow run 12924470121

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30202

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.9 MB 77.9 MB 0 B 2.24 0%
initSize 131 MB 132 MB 847 kB 34.71 0.6%
diffSize 53 MB 53.8 MB 847 kB 57.19 1.6%
buildSize 7.19 MB 7.19 MB 39 B 0.4 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B -0.33 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B 0.33 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B 0.33 0%
buildPreviewSize 3.28 MB 3.28 MB 39 B 0.66 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.3s 23.9s 15.5s 1.45 🔺64.9%
generateTime 20.5s 20.9s 420ms 0.11 2%
initTime 13s 15s 2s 0.15 13.4%
buildTime 8.7s 7.7s -1s -56ms -1.83 🔰-13.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.3s 5.9s 556ms 2.39 🔺9.4%
devManagerResponsive 3.9s 4.1s 261ms 2.62 🔺6.3%
devManagerHeaderVisible 616ms 648ms 32ms 1.13 4.9%
devManagerIndexVisible 649ms 686ms 37ms 0.84 5.4%
devStoryVisibleUncached 2.2s 2.1s -107ms 0.91 -5%
devStoryVisible 650ms 687ms 37ms 1.27 🔺5.4%
devAutodocsVisible 554ms 499ms -55ms -0.34 -11%
devMDXVisible 583ms 565ms -18ms 0.48 -3.2%
buildManagerHeaderVisible 682ms 646ms -36ms 1.2 -5.6%
buildManagerIndexVisible 776ms 744ms -32ms 1.24 -4.3%
buildStoryVisible 655ms 620ms -35ms 1.12 -5.6%
buildAutodocsVisible 505ms 511ms 6ms 0.45 1.2%
buildMDXVisible 556ms 527ms -29ms 1.22 -5.5%

Copy link

nx-cloud bot commented Jan 7, 2025

View your CI Pipeline Execution ↗ for commit a594eea.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 11:37:37 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Jan 7, 2025

Package Benchmarks

Commit: a594eea, ran on 28 January 2025 at 11:42:38 UTC

The following packages have significant changes to their size or dependencies:

@storybook/experimental-addon-test

Before After Difference
Dependency count 60 60 0
Self size 832 KB 846 KB 🚨 +14 KB 🚨
Dependency size 14.19 MB 14.19 MB 🚨 +78 B 🚨
Bundle Size Analyzer Link Link

@storybook/core

Before After Difference
Dependency count 54 55 🚨 +1 🚨
Self size 19.04 MB 19.64 MB 🚨 +599 KB 🚨
Dependency size 14.44 MB 14.73 MB 🚨 +290 KB 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 55 56 🚨 +1 🚨
Self size 22 KB 24 KB 🚨 +2 KB 🚨
Dependency size 33.49 MB 34.38 MB 🚨 +889 KB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 56 57 🚨 +1 🚨
Self size 1 KB 1 KB 0 B
Dependency size 33.51 MB 34.40 MB 🚨 +890 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 388 396 🚨 +8 🚨
Self size 503 KB 248 KB 🎉 -255 KB 🎉
Dependency size 75.27 MB 77.22 MB 🚨 +1.95 MB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 277 278 🚨 +1 🚨
Self size 612 KB 612 KB 0 B
Dependency size 65.36 MB 66.24 MB 🚨 +889 KB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 113 139 🚨 +26 🚨
Self size 1.11 MB 1.72 MB 🚨 +609 KB 🚨
Dependency size 42.62 MB 46.93 MB 🚨 +4.31 MB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen self-assigned this Jan 8, 2025
ndelangen and others added 30 commits January 22, 2025 11:14
…it will handle the telemetry notification itself
…y we can accurately detect the user passing the flag, and skip the step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants