Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Rename a11ytest tag to a11y-test #30198

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Jan 6, 2025

What I did

See title

Checklist for Contributors

Testing

N/A — Find/replace in docs only

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Renamed accessibility test tag from 'a11ytest' to 'a11y-test' across documentation files to improve readability while maintaining functionality.

  • Updated tag name in docs/writing-tests/accessibility-testing.mdx for main accessibility testing documentation
  • Changed tag references in docs/_snippets/addon-a11y-meta-tag.md across multiple framework examples
  • Updated both positive ('a11y-test') and negative ('!a11y-test') tag references in docs/_snippets/storybook-test-addon-disable-tests.md

💡 (5/5) You can turn off certain types of comments like style here!

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Jan 6, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Jan 6, 2025

View your CI Pipeline Execution ↗ for commit 103267b.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 14:28:55 UTC

@valentinpalkovic valentinpalkovic merged commit 732f0c3 into next Jan 7, 2025
9 of 12 checks passed
@valentinpalkovic valentinpalkovic deleted the docs-a11y-test-tag branch January 7, 2025 13:43
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants