-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: E2E tests for new Component Testing features #29826
Merged
Merged
Changes from 36 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
82e0c62
ugprade vitest dependencies to 2.1.6
JReinhold 1373b36
improve type-safety in coverage reporter
JReinhold e111a2d
add coverage E2E test, a11y labels to coverage UI
JReinhold 291a70a
Merge branch 'next' of github.com:storybookjs/storybook into 29745-e2…
JReinhold 1dd20b7
Merge branch 'norbert/vitest-support-preview-html' of github.com:stor…
JReinhold c91f604
commit stuff - not done
JReinhold eb1a526
add an experimentalLoadStorybook api
ndelangen 41a0c7a
cleanup
ndelangen 6f48ea8
fix coverage+watch test
JReinhold 269f1a2
fix tests
JReinhold 0c76a0e
Merge branch 'norbert/vitest-support-preview-html' into 29745-e2e-tes…
JReinhold bc52357
fix story types
JReinhold b4154f5
Merge branch '29745-e2e-tests-for-testing-improvements' of github.com…
JReinhold 87fa9ba
better comments
JReinhold 23f4967
add non-failing-vitest to ci
JReinhold d1441aa
fix vitest/ui dep
JReinhold b5b65b0
simplify coverage+focus test
JReinhold 1b86bf3
revert vitest upgrades
JReinhold a5034d8
Merge branch 'norbert/vitest-support-preview-html' into 29745-e2e-tes…
JReinhold ab5be7f
Merge branch 'norbert/vitest-support-preview-html' of github.com:stor…
JReinhold 5a9ba43
Merge branch '29745-e2e-tests-for-testing-improvements' of github.com…
JReinhold b8c9393
revert yarn.lock changes.
JReinhold f47acc5
add staticDirs test
JReinhold 0a5a607
add test for vitefinal
JReinhold b4f4965
Merge branch 'norbert/vitest-support-preview-html' of github.com:stor…
JReinhold 5813cd4
Merge branch 'norbert/vitest-support-preview-html' of github.com:stor…
JReinhold 17a01ee
cleanup
JReinhold 0367631
Merge branch 'next' of github.com:storybookjs/storybook into 29745-e2…
JReinhold 11a25dc
cleanup
JReinhold 58afdd4
Merge branch 'jeppe/fix-duplicate-include' of github.com:storybookjs/…
JReinhold e7a5eb2
Merge branch 'next' of github.com:storybookjs/storybook into 29745-e2…
JReinhold 65f6411
fix e2e tests 🤞
JReinhold 0225d09
speedup kitchen sink storybook
JReinhold 1765262
add fail-on-purpose tag to Button story
JReinhold 64d9692
Merge branch 'next' into 29745-e2e-tests-for-testing-improvements
JReinhold 8128b6f
Merge branch 'next' into 29745-e2e-tests-for-testing-improvements
ndelangen 041d195
Update code/addons/test/src/components/TestProviderRender.tsx
JReinhold a2dc9e1
Merge branch 'next' into 29745-e2e-tests-for-testing-improvements
JReinhold 1fca1f6
fix format
JReinhold a19b0f5
reuse existing vitest script
JReinhold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
test-storybooks/portable-stories-kitchen-sink/react/.storybook/aliased.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// This file is used to test that viteFinal is correctly loaded in Vitest | ||
// main.ts defines this file as a resolve alias, which is used in the ViteFinalTest story | ||
|
||
export const aliasedFunction = () => true; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
test-storybooks/portable-stories-kitchen-sink/react/.storybook/test-static-dirs/static.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// This file is used to test that staticDirs are correctly loaded in Vitest | ||
|
||
export const staticFunction = () => true; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? If you want the vitest script to be tested as part of CI, just move the contents of
vitest-skip-fail-on-purpose
and move it tovitest
, which will be automatically run as part of this CI step:https://github.com/storybookjs/storybook/blob/29745-e2e-tests-for-testing-improvements/.circleci/config.yml#L794
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah that's much better, it's to test these scenarios: https://github.com/storybookjs/storybook/pull/29826/files#diff-0550ef2a360c5242f25677cd964d3afce1c0412497a76eded7d03c0838941611R68-R92
Another alternative would be to move those stories into the UI Storybook instead, no strong opinion.