-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Build: Migrate repo to Nx 20" #29820
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Removing this file will cause vite.config timestamp files to be tracked in git. Consider keeping the ignore rule by moving it to the root .gitignore instead. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,3 @@ | |
|
||
/.nx/cache | ||
core/report | ||
|
||
/.nx/workspace-data |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"migrations": [ | ||
{ | ||
"cli": "nx", | ||
"version": "17.3.0-beta.6", | ||
"description": "Updates the nx wrapper.", | ||
"implementation": "./src/migrations/update-17-3-0/update-nxw", | ||
"package": "nx", | ||
"name": "17.3.0-update-nx-wrapper" | ||
}, | ||
{ | ||
"cli": "nx", | ||
"version": "18.0.0-beta.2", | ||
"description": "Updates .env to disabled adding plugins when generating projects in an existing Nx workspace", | ||
"implementation": "./src/migrations/update-18-0-0/disable-crystal-for-existing-workspaces", | ||
"x-repair-skip": true, | ||
"package": "nx", | ||
"name": "18.0.0-disable-adding-plugins-for-existing-workspaces" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,16 @@ | ||
{ | ||
"$schema": "./node_modules/nx/schemas/nx-schema.json", | ||
"extends": "nx/presets/npm.json", | ||
"cacheDirectory": "../.nx/cache", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: cacheDirectory is deprecated in newer Nx versions and should be removed. It defaults to .nx/cache in the workspace root. |
||
"nxCloudAccessToken": "NGVmYTkxMmItYzY3OS00MjkxLTk1ZDktZDFmYTFmNmVlNGY4fHJlYWQ=", | ||
"defaultBase": "next", | ||
"parallel": 8, | ||
"affected": { | ||
"defaultBase": "next" | ||
}, | ||
Comment on lines
+8
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: affected.defaultBase is redundant with the top-level defaultBase setting on line 6 |
||
"cli": { | ||
"packageManager": "yarn" | ||
}, | ||
"plugins": [ | ||
{ | ||
"plugin": "@nx/vite/plugin", | ||
|
@@ -131,7 +138,7 @@ | |
"sharedGlobals": ["{workspaceRoot}/tsconfig.json"], | ||
"production": [ | ||
"default", | ||
"!{projectRoot}/src/**/**/*.{test,spec,stories}.?(c|m)[jt]s?(x)?(.snap)", | ||
"!{projectRoot}/src/**/**/*.{test,spec,stories}.?(c|m)[jt]s?(x)?(.snap),", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: invalid glob pattern - trailing comma inside the pattern will cause file matching issues |
||
"!{projectRoot}/vitest.config.[jt]s", | ||
"!{projectRoot}/README.md", | ||
"!{projectRoot}/.eslintrc.{json,js}", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: consider keeping .nx/workspace-data ignored to prevent committing temporary Nx workspace data