Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add addon a11y to sandbox tests #29764

Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 2, 2024

Building on top of #29643

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B -0.45 0%
initSize 130 MB 130 MB 0 B -1 0%
diffSize 52.5 MB 52.5 MB 0 B -0.99 0%
buildSize 6.76 MB 6.76 MB 37 B -2.38 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B 0.88 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -0.23 0%
buildSbPreviewSize 0 B 0 B 0 B -2.38 -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.57 MB 3.57 MB 0 B -2.38 0%
buildPreviewSize 3.19 MB 3.19 MB 37 B 2.38 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 27.3s 15.4s -11s -899ms -0.06 -77.1%
generateTime 20.4s 21s 657ms -0.11 3.1%
initTime 13.9s 13.8s -44ms -0.44 -0.3%
buildTime 9.5s 8.2s -1s -304ms -0.54 -15.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.6s 5.4s -215ms -0.02 -3.9%
devManagerResponsive 4s 3.8s -122ms 0.7 -3.1%
devManagerHeaderVisible 609ms 638ms 29ms 0.29 4.5%
devManagerIndexVisible 717ms 675ms -42ms 0 -6.2%
devStoryVisibleUncached 2s 1.8s -236ms 1.01 -12.9%
devStoryVisible 716ms 673ms -43ms 0.06 -6.4%
devAutodocsVisible 544ms 587ms 43ms 0.49 7.3%
devMDXVisible 533ms 709ms 176ms 1.99 🔺24.8%
buildManagerHeaderVisible 603ms 557ms -46ms -0.17 -8.3%
buildManagerIndexVisible 692ms 628ms -64ms 0.31 -10.2%
buildStoryVisible 548ms 510ms -38ms -0.55 -7.5%
buildAutodocsVisible 523ms 456ms -67ms -0.03 -14.7%
buildMDXVisible 492ms 432ms -60ms -0.38 -13.9%

Greptile Summary

This PR reorganizes accessibility testing files by moving a11y stories to their proper location and integrates the a11y addon into sandbox testing configurations.

  • Relocated A11YPanel.stories.tsx and TestDiscrepancyMessage.stories.tsx from template directory to code/addons/a11y/src/components/
  • Updated import paths in stories files to use relative paths
  • Added @storybook/addon-a11y to sandbox setup when Vitest integration is enabled
  • Added a11y parameters in preview config for vite-based projects

@yannbf yannbf changed the title move internal a11y stories to the right directory Build: Add addon a11y to sandbox tests Dec 2, 2024
@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. ci:normal and removed ci:daily Run the CI jobs that normally run in the daily job. labels Dec 2, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 451 to 460
const annotations = setProjectAnnotations([
${isVue ? 'vueAnnotations,' : ''}
rendererDocsAnnotations,
projectAnnotations,
coreAnnotations,
toolbarAnnotations,
addonActionsAnnotations,
addonTestAnnotations,
${isVue ? 'vueAnnotations,' : ''}
addonA11yAnnotations,
projectAnnotations,
])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: ensure consistent order of annotations - framework specific (Vue) first, then core features, then addons, then project level

Copy link

nx-cloud bot commented Dec 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1294596. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Dec 6, 2024
@yannbf yannbf force-pushed the yann/add-a11y-addon-to-sandboxes branch from a4dd68e to fd475c5 Compare December 6, 2024 14:07
@kasperpeulen kasperpeulen merged commit 19468e4 into valentin/unified-a11y-testing Dec 6, 2024
4 of 5 checks passed
@kasperpeulen kasperpeulen deleted the yann/add-a11y-addon-to-sandboxes branch December 6, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants