Release: Prerelease 8.4.0-alpha.3 #29248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates away from chalk to picocolors instead, primarily because the latter is _much_ lighter. Keep in mind, `node-logger` still uses chalk as we use `hex(code)` which doesn't have an alternative in picocolors. This means it will still be in the dependency tree for many packages (for now). This seems preferable over upgrading chalk since the latest version of chalk will still be heavier, and is ESM-only (not sure if we're able to adopt ESM only deps in SB yet).
Moves the `manager-api`, `preview-api` and `ui/amanger` to use `picoquery` instead of `qs` - a much smaller and faster alternative. Note that we still have `qs` in our overall monorepo tree, but that can be tackled in a follow-up PR.
Uses the `foo.bar[0]` syntax picoquery provides, rather than dot-syntax (`foo.bar.0`).
Moves the preview api to use picoquery. Note that tests will not pass yet.
Decodes certain chars we want to keep in our URIs (e.g. `[`).
…o resize on hot reloads
A11y: Improve test runner recipe
Docs: NextJs framework fix viteFinal link
Core: Migrate from `qs` to `picoquery`
There was a problem hiding this comment.
LGTM
20 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
UI: Brand image css class conflict causes image to resize on hot reloads
c5e4be3 to
853adf0
Compare
CLI: Migrate from `chalk` to `picocolors`
853adf0 to
9f0d295
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9f0d295. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.4.0-alpha.2to8.4.0-alpha.3.Once this pull request is merged, it will trigger a new release of version
8.4.0-alpha.3.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:chalktopicocolors#28262qstopicoquery#28315If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0-alpha.3
chalktopicocolors- #28262, thanks @43081j!qstopicoquery- #28315, thanks @43081j!