Release: Patch 8.3.4 #29211
Merged
Release: Patch 8.3.4 #29211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9839e69 to
ba29733
Compare
There was a problem hiding this comment.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -135,7 +136,7 @@ export const Exception = ({ exception }: { exception: Call['exception'] }) => { | |||
| const more = paragraphs.length > 1; | |||
| return ( | |||
| <RowMessage> | |||
| <pre>{paragraphs[0]}</pre> | |||
| <pre dangerouslySetInnerHTML={{ __html: filter.toHtml(paragraphs[0]) }}></pre> | |||
There was a problem hiding this comment.
style: Use of dangerouslySetInnerHTML may pose security risks if not properly sanitized
Comment on lines
+137
to
+139
| dangerouslySetInnerHTML={{ | ||
| __html: filter.toHtml(printSerializedError(caughtException)), | ||
| }} |
There was a problem hiding this comment.
style: Use of dangerouslySetInnerHTML might pose security risks if not properly sanitized
e580a4a to
e2c4d9c
Compare
e2c4d9c to
4387c68
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4387c68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.3.3to8.3.4.Once this pull request is merged, it will trigger a new release of version
8.3.4.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.3.4