Convert installation instructions #21361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- From FeatureSnippets to CodeSnippets - Append `@next` to `storybook` - Remove `ember` snippet
|
lgtm |
domyen
approved these changes
Mar 2, 2023
jonniebigodes
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Thanks for the updates, appreciate it 🙏 ! Looks great on my end. Merge away @kylegach
domyen
requested changes
Mar 2, 2023
domyen
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
@nexttostorybookembersnippetBefore
After
Notes
There were two cases that didn't fit the simplified case I ended up with:
ember: There wasn't even adocs/snippets/emberdirectory, so I'm not sure it should even be listed as a renderer in the docs site.angular: The prior instructions only usednpxand notpnmp. Seemed reasonable to include both.Without simplifying to use the
docs/snippets/commondirectory, the tabs also displayed the renderer name:That seemed a bit confusing to me, as the installation instructions don't actually differ between renderers (assuming I'm OK in simplifying the two cases above) and its weird to conceptually combine the package manager and the renderer.
How to test
Follow the snippet contribution instructions for this branch
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]