Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setGlobalConfig with setProjectAnnotations #17812

Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 29, 2022

Issue: N/A

What I did

Apply review comments to #17282

How to test

N/A

@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0796d7e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Mar 29, 2022
@shilman shilman requested review from yannbf and tmeasday March 29, 2022 02:09
@shilman
Copy link
Member Author

shilman commented Mar 29, 2022

@yannbf a bunch of TS errors when you run yarn build-storybook in cra-ts-essentials. can you please fix them so we can merge?

@yannbf
Copy link
Member

yannbf commented Mar 29, 2022

@yannbf a bunch of TS errors when you run yarn build-storybook in cra-ts-essentials. can you please fix them so we can merge?

pushed!

@shilman
Copy link
Member Author

shilman commented Mar 29, 2022

@yannbf still failing

ERR! /tmp/storybook/examples/cra-ts-essentials/src/stories/1-Button.stories.tsx
ERR! TypeScript error in /tmp/storybook/examples/cra-ts-essentials/src/stories/1-Button.stories.tsx(13,6):
ERR! Property 'args' does not exist on type '(args: any) => Element'.  TS2339
ERR! 
ERR!     11 | 
ERR!     12 | export const Text = Template.bind({});
ERR!   > 13 | Text.args = {
ERR!        |      ^
ERR!     14 |   children: 'Hello button',
ERR!     15 | };
ERR!     16 | 

@yannbf
Copy link
Member

yannbf commented Mar 29, 2022

@yannbf still failing

ERR! /tmp/storybook/examples/cra-ts-essentials/src/stories/1-Button.stories.tsx
ERR! TypeScript error in /tmp/storybook/examples/cra-ts-essentials/src/stories/1-Button.stories.tsx(13,6):
ERR! Property 'args' does not exist on type '(args: any) => Element'.  TS2339
ERR! 
ERR!     11 | 
ERR!     12 | export const Text = Template.bind({});
ERR!   > 13 | Text.args = {
ERR!        |      ^
ERR!     14 |   children: 'Hello button',
ERR!     15 | };
ERR!     16 | 

sorry about that! pushed

@yannbf yannbf merged commit 92df4f3 into feat/testing-utilities Mar 29, 2022
@yannbf yannbf deleted the fix/testing-utils-set-project-annotations branch March 29, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants