Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : add missing await for an async function #17729

Merged
merged 1 commit into from
Mar 21, 2022
Merged

fix : add missing await for an async function #17729

merged 1 commit into from
Mar 21, 2022

Conversation

ch3coo2ca
Copy link
Contributor

Issue: await is missing in async functions

What I did

added missing await for an async function

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 16, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 05fd898. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@MichaelArestad MichaelArestad added the maintenance User-facing maintenance tasks label Mar 21, 2022
MichaelArestad
MichaelArestad approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch addon: interactions and removed maintenance User-facing maintenance tasks labels Mar 21, 2022
@shilman shilman merged commit b8ccc17 into storybookjs:next Mar 21, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2022
shilman added a commit that referenced this pull request Apr 1, 2022
@shilman
Merge pull request #17729 from ch3coo2ca/fix-missing-await
4b2662d 
fix : add missing await for an async function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelArestad MichaelArestad MichaelArestad approved these changes

Assignees
No one assigned
Labels
addon: interactions documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ch3coo2ca @MichaelArestad @shilman