Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs #17718

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix typo in docs #17718

merged 1 commit into from
Mar 21, 2022

Conversation

JodiWarren
Copy link
Contributor

Issue:

What I did

A documentation link was broken in this example. I added the missing /.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 15, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 7d17ecd.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you take a quick look to see if this typo is in other files as well?

@MichaelArestad MichaelArestad self-assigned this Mar 21, 2022
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 21, 2022
@jonniebigodes
Copy link
Contributor

@JodiWarren thanks for taking the time to create this pull request and help us improve our documentation by fixing this small but rather an important typo. We appreciate it. To give a bit more context on the question @MichaelArestad asked. That's already fixed with a recent pull request that was merged. With that in mind, I'm going to merge this.

Hope you have a fantastic week!

Looking forward to your next contribution.

Stay safe

@jonniebigodes jonniebigodes merged commit 761ec25 into storybookjs:next Mar 21, 2022
@JodiWarren JodiWarren deleted the patch-1 branch March 24, 2022 10:48
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2022
shilman pushed a commit that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants