Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : typo in props name #17716

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix : typo in props name #17716

merged 1 commit into from
Mar 15, 2022

Conversation

ch3coo2ca
Copy link
Contributor

Issue:

What I did

I fixed typo of wrong props name in react document snippets.
I found that some example snippets take background props and some take backgroundColor props,
so I fixed background to backgroundColor.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 15, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 4c6e17d.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 15, 2022
@jonniebigodes
Copy link
Contributor

@ch3coo2ca thanks for taking the time and effort to help us fix the documentation by catching this small but rather an important typo. We appreciate it. I've checked and all is good on my end. Going to merge this.

Hope you have a great week!

Stay safe

@jonniebigodes jonniebigodes merged commit fc5a9b3 into storybookjs:next Mar 15, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2022
shilman pushed a commit that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants