-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add Preact code snippet for Whats a Story #17554
Docs: Add Preact code snippet for Whats a Story #17554
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 40f9834. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbredius thanks for the time and effort you've put into this pull request and your willingness to help us improve our documentation and include Preact snippets.
Don't worry about anything me and the other maintainers will try our best to help with your contributions and our community is also a great one that can help you as well.
One small tweak to the snippet and this will be good to go. Let me know once you've addressed it and I'll gladly merge it. With that in mind, we'll be looking forward to your next pull request with more Preact snippets.
Have a fantastic day!
Stay safe
export default { | ||
title: 'Button', | ||
component: Button, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbredius if you could update the snippet and only use 2 spaces instead of 4 we'd appreciate it:
With that in mind the default export would be as such:
export default {
title: 'Button',
component: Button,
}
This is basically to remain consistent, as some environments/setups might be configured for 4 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonniebigodes for your help! Have a great day as well.
0735efa
to
40f9834
Compare
Thanks for taking care of this so promptly, appreciate it. going to merge this! |
Docs: Add Preact code snippet for Whats a Story
What I did
I added a Preact code snipped for the
Get Started
->What's a Story
page. It is my first ever open source PR, so please be kind 😄. Once this is merged, I will add more code snippets for Preact.How to test
Feedback is always welcome!