Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Preact code snippet for Whats a Story #17554

Merged

Conversation

fbredius
Copy link
Contributor

What I did

I added a Preact code snipped for the Get Started -> What's a Story page. It is my first ever open source PR, so please be kind 😄. Once this is merged, I will add more code snippets for Preact.

How to test

  • Please read the files to check whether I adhere to the contributing guidelines.

Feedback is always welcome!

@nx-cloud
Copy link

nx-cloud bot commented Feb 23, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 40f9834. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbredius thanks for the time and effort you've put into this pull request and your willingness to help us improve our documentation and include Preact snippets.

Don't worry about anything me and the other maintainers will try our best to help with your contributions and our community is also a great one that can help you as well.

One small tweak to the snippet and this will be good to go. Let me know once you've addressed it and I'll gladly merge it. With that in mind, we'll be looking forward to your next pull request with more Preact snippets.

Have a fantastic day!

Stay safe

Comment on lines 8 to 11
export default {
title: 'Button',
component: Button,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbredius if you could update the snippet and only use 2 spaces instead of 4 we'd appreciate it:
With that in mind the default export would be as such:

export default {
  title: 'Button',
  component: Button,
}

This is basically to remain consistent, as some environments/setups might be configured for 4 spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonniebigodes for your help! Have a great day as well.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 23, 2022
@jonniebigodes jonniebigodes self-assigned this Feb 23, 2022
@fbredius fbredius force-pushed the docs/add-snippet-for-preact branch from 0735efa to 40f9834 Compare February 24, 2022 08:35
@jonniebigodes
Copy link
Contributor

Thanks for taking care of this so promptly, appreciate it. going to merge this!

@jonniebigodes jonniebigodes merged commit 59fa268 into storybookjs:next Feb 24, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 7, 2022
shilman pushed a commit that referenced this pull request Mar 7, 2022
Docs: Add Preact code snippet for Whats a Story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants