Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest-image-snapshot link #17351

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Fix jest-image-snapshot link #17351

merged 2 commits into from
Feb 7, 2022

Conversation

yhor1e
Copy link
Contributor

@yhor1e yhor1e commented Jan 27, 2022

Issue: N/A

What I did

The link [jest-image-snapshot](https://github.com/storybookjs/storybook/tree/master/addons/storyshots#configure-storyshots-for-image-snapshots) is not correct. https://github.com/storybookjs/storybook/tree/master/addons/storyshots page doesn't have #configure-storyshots-for-image-snapshots content.

ref:

For a self-managed alternative to Chromatic, we offer [StoryShots](https://github.com/storybookjs/storybook/tree/master/addons/storyshots). It allows you to run visual tests on stories by integrating with [jest-image-snapshot](https://github.com/storybookjs/storybook/tree/master/addons/storyshots#configure-storyshots-for-image-snapshots).

I think https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-puppeteer#imagesnapshots is correct and fix it.

Please merge this PR if you need or close it if you don't need.

Thank you for your time in advance.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 27, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit ee3b7a0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 7, 2022
@yannbf
Copy link
Member

yannbf commented Feb 7, 2022

Hey @yhor1e thank you so much for your contribution! Great catch 👍

@shilman shilman merged commit 5c5fef9 into storybookjs:next Feb 7, 2022
@yhor1e yhor1e deleted the patch-1 branch February 7, 2022 21:16
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 12, 2022
shilman added a commit that referenced this pull request Feb 12, 2022
Fix jest-image-snapshot link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants