Core: Fix process.env assignment #17174
Merged
+14
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17128
What I did
Remove
process.env
definition.process.env.FOO = 'bar';
succeed.const { FOO } = process.env;
will failGiven that nobody complained about the latter and lots of people are complaining about the former, I think this is a good tradeoff.
@tmeasday there's probably a smarter way to get both cases. Any ideas?
How to test
See updates to
react-ts
example