Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: (Docs) Updates to the sidebar toc file #17124

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Chore: (Docs) Updates to the sidebar toc file #17124

merged 1 commit into from
Jan 7, 2022

Conversation

jonniebigodes
Copy link
Contributor

With this pull request, the documentation structure (i.e., the toc.js file) is organized to conciseness.

What was done:

  • Moved the Essentials addons and Addons upwards in the hierarchy and one after the other. The reasoning behind this is that we start by introducing people to the Essentials addons and how to use them and immediately after that we let them know how to write their own Storybook addon.

@kylegach and @domyen are you both ok with this?

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 4, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jan 4, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit 6c1c18d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

kylegach
kylegach approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change. 💯

@shilman shilman merged commit 64baffd into next Jan 7, 2022
@shilman shilman deleted the chore_fix_toc branch January 7, 2022 13:36
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 10, 2022
shilman added a commit that referenced this pull request Jan 10, 2022
@shilman
Merge pull request #17124 from storybookjs/chore_fix_toc
7d4c865 
Chore: (Docs) Updates to the sidebar toc file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegach kylegach kylegach approved these changes

@domyen domyen Awaiting requested review from domyen

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonniebigodes @kylegach @shilman