Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyshots: Support main.js usage #13842

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 9, 2021

Issue: #7959

What I did

Added empty preset to storyshots packages, which allow them to be used in main.js (as no-op)

How to test

See react-ts example

@shilman shilman added bug addon: storyshots patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 9, 2021
@shilman shilman added this to the 6.1.x milestone Feb 9, 2021
@phated
Copy link
Contributor

phated commented Feb 9, 2021

Nice!

@shilman shilman merged commit b76f5f7 into next Feb 10, 2021
@shilman shilman deleted the 7959-fix-storyshots-as-addon branch February 10, 2021 15:20
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 14, 2021
shilman added a commit that referenced this pull request Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: storyshots bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants