-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-popper-tooltip and @popperjs/core for react17 #13434
Update react-popper-tooltip and @popperjs/core for react17 #13434
Conversation
Other warings.(my case)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are awesome @matamatanot. Thank you!
CI seems to be failing but hopefully unrelated to this PR. Trying again...
@@ -5233,13 +5233,6 @@ | |||
resolved "https://registry.yarnpkg.com/@types/util-deprecate/-/util-deprecate-1.0.0.tgz#341d0815fe5a661b94e3ea738d182b4c359e3958" | |||
integrity sha512-I2vixiQ+mrmKxfdLNvaa766nulrMVDoUQiSQoNeTjFUNAt8klnMgDh3yy/bH/r275357q30ACOEUaxFOR8YVrA== | |||
|
|||
"@types/webpack-bundle-analyzer@^3.9.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part the reason for the failure?
I couldn't see @types/webpack-bundle-analyzer
in the stale lockfile diff of popper-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing it was an intermittent failure. We run so many builds that every now and then something gets corrupted. It seems to have fixed itself when I re-ran the job.
…ip-for-react-17 Update react-popper-tooltip and @popperjs/core for react17
Issue:
My projects use
react@17
.yarn install
warning @storybook/addon-actions > @storybook/components > react-popper-tooltip@3.1.0" has incorrect peer dependency "react-dom@^16.6.0".
What I did
Update dependancies.
x-refs