Skip to content

Commit

Permalink
Merge pull request #29528 from storybookjs/version-non-patch-from-8.5…
Browse files Browse the repository at this point in the history
….0-alpha.2

Release: Prerelease 8.5.0-alpha.3
  • Loading branch information
shilman authored Nov 5, 2024
2 parents 82f7c96 + e9d6e29 commit 22f8ad4
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 14 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.prerelease.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 8.5.0-alpha.3

- Addon Test: Fix post-install logic for Next.js Vite framework support - [#29524](https://github.com/storybookjs/storybook/pull/29524), thanks @valentinpalkovic!
- Core: Prevent clipping box shadow on file search modal - [#29523](https://github.com/storybookjs/storybook/pull/29523), thanks @ghengeveld!

## 8.5.0-alpha.2

- Addon Test: Only render the TestingModule component in development mode - [#29501](https://github.com/storybookjs/storybook/pull/29501), thanks @yannbf!
Expand Down
6 changes: 4 additions & 2 deletions code/addons/test/src/postinstall.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ export default async function postInstall(options: PostinstallOptions) {
'@storybook/experimental-nextjs-vite',
'@storybook/sveltekit',
].includes(info.frameworkPackageName)
? info.frameworkPackageName
? info.frameworkPackageName === '@storybook/nextjs'
? '@storybook/experimental-nextjs-vite'
: info.frameworkPackageName
: info.rendererPackageName &&
['@storybook/react', '@storybook/svelte', '@storybook/vue3'].includes(
info.rendererPackageName
Expand Down Expand Up @@ -431,7 +433,7 @@ const getVitestPluginInfo = (framework: string) => {
let frameworkPluginCall = '';
let frameworkPluginDocs = '';

if (framework === '@storybook/nextjs') {
if (framework === '@storybook/nextjs' || framework === '@storybook/experimental-nextjs-vite') {
frameworkPluginImport =
"import { storybookNextJsPlugin } from '@storybook/experimental-nextjs-vite/vite-plugin';";
frameworkPluginDocs =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const MODAL_HEIGHT = 418;
const ModalStyled = styled(Modal)(() => ({
boxShadow: 'none',
background: 'transparent',
overflow: 'visible',
}));

const ModalChild = styled.div<{ height?: number }>(({ theme, height }) => ({
Expand Down
8 changes: 5 additions & 3 deletions code/core/src/manager/components/sidebar/Heading.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ export default {
} as Meta<typeof Heading>;

const menuItems = [
{ title: 'Menu Item 1', onClick: action('onActivateMenuItem'), id: '1' },
{ title: 'Menu Item 2', onClick: action('onActivateMenuItem'), id: '2' },
{ title: 'Menu Item 3', onClick: action('onActivateMenuItem'), id: '3' },
[
{ title: 'Menu Item 1', onClick: action('onActivateMenuItem'), id: '1' },
{ title: 'Menu Item 2', onClick: action('onActivateMenuItem'), id: '2' },
{ title: 'Menu Item 3', onClick: action('onActivateMenuItem'), id: '3' },
],
];

export const MenuHighlighted: Story = () => (
Expand Down
11 changes: 6 additions & 5 deletions code/core/src/manager/components/sidebar/Menu.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { ComponentProps } from 'react';
import React from 'react';

import { TooltipLinkList } from '@storybook/core/components';
Expand All @@ -11,11 +10,13 @@ import type { State } from '@storybook/core/manager-api';

import { useMenu } from '../../container/Menu';
import { LayoutProvider } from '../layout/LayoutProvider';
import { SidebarMenu } from './Menu';
import { type MenuList, SidebarMenu } from './Menu';

const fakemenu: ComponentProps<typeof TooltipLinkList>['links'] = [
{ title: 'has icon', icon: <LinkIcon />, id: 'icon' },
{ title: 'has no icon', id: 'non' },
const fakemenu: MenuList = [
[
{ title: 'has icon', icon: <LinkIcon />, id: 'icon' },
{ title: 'has no icon', id: 'non' },
],
];

const meta = {
Expand Down
2 changes: 0 additions & 2 deletions code/frameworks/nextjs/src/routing/app-router-provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ function getSelectedParams(currentTree: FlightRouterState, params: Params = {}):
continue;
}

// Ensure catchAll and optional catchall are turned into an array

// Ensure catchAll and optional catchall are turned into an array
const isCatchAll = isDynamicParameter && (segment[2] === 'c' || segment[2] === 'oc');

Expand Down
3 changes: 2 additions & 1 deletion code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -293,5 +293,6 @@
"Dependency Upgrades"
]
]
}
},
"deferredNextVersion": "8.5.0-alpha.3"
}
2 changes: 1 addition & 1 deletion docs/versions/next.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"8.5.0-alpha.2","info":{"plain":"- Addon Test: Only render the TestingModule component in development mode - [#29501](https://github.com/storybookjs/storybook/pull/29501), thanks @yannbf!\n- CLI: Fix Solid init by installing `@storybook/test` - [#29514](https://github.com/storybookjs/storybook/pull/29514), thanks @shilman!\n- Core: Add bun support with npm fallback - [#29267](https://github.com/storybookjs/storybook/pull/29267), thanks @stephenjason89!\n- Core: Shim CJS-only globals in ESM output - [#29157](https://github.com/storybookjs/storybook/pull/29157), thanks @valentinpalkovic!\n- Next.js: Fix bundled react and react-dom in monorepos - [#29444](https://github.com/storybookjs/storybook/pull/29444), thanks @sentience!\n- Next.js: Upgrade sass-loader from ^13.2.0 to ^14.2.1 - [#29264](https://github.com/storybookjs/storybook/pull/29264), thanks @HoncharenkoZhenya!\n- UI: Add support for groups to `TooltipLinkList` and use it in main menu - [#29507](https://github.com/storybookjs/storybook/pull/29507), thanks @ghengeveld!"}}
{"version":"8.5.0-alpha.3","info":{"plain":"- Addon Test: Fix post-install logic for Next.js Vite framework support - [#29524](https://github.com/storybookjs/storybook/pull/29524), thanks @valentinpalkovic!\n- Core: Prevent clipping box shadow on file search modal - [#29523](https://github.com/storybookjs/storybook/pull/29523), thanks @ghengeveld!"}}

0 comments on commit 22f8ad4

Please sign in to comment.