Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support webpack 5, expose some types #32

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Only support webpack 5, expose some types #32

merged 3 commits into from
Dec 14, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 14, 2022

Issue: #

What Changed

We lost #28 in #30, so this re-exports a few types that are useful when interacting with this package. It will be useful to avoid duplicating the types here: https://github.com/storybookjs/storybook/pull/20271/files#diff-e3d50a086df937d7c8f41d5819f0e6d8368961c112866cc291cfe057a4fafe23R10

It also removes some logic that was supporting webpack 4.

How to test

Change Type

  • maintenance
  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: 0.0.4-canary.32.e03c3aa.0

✨ Test out this PR locally via:

npm install @storybook/mdx2-csf@0.0.4-canary.32.e03c3aa.0
# or 
yarn add @storybook/mdx2-csf@0.0.4-canary.32.e03c3aa.0

Version

Published prerelease version: v1.0.0-next.2

Changelog

💥 Breaking Change

  • Add JSX transpilation to compiler-generated code #30 (@ndelangen)

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to next

Authors: 8

@IanVS IanVS requested review from shilman and ndelangen December 14, 2022 14:34
@IanVS
Copy link
Member Author

IanVS commented Dec 14, 2022

I could use help with tags, etc. on this.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@shilman shilman merged commit 32d5c6e into next Dec 14, 2022
@IanVS IanVS deleted the cleanup branch December 14, 2022 14:51
@github-actions github-actions bot mentioned this pull request Dec 30, 2022
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 21, 2023
5 tasks
This was referenced Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants