Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

fix(app): add logic for component inheritance #80

Merged
merged 1 commit into from
Apr 6, 2020
Merged

fix(app): add logic for component inheritance #80

merged 1 commit into from
Apr 6, 2020

Conversation

tripodsan
Copy link
Contributor

Issue:
relates to #45

What I did

  • added logic to component loader to resolve the script based on sling:resourceSuperType
  • import some of the aem-core-components in the aem-kitchen-sink and created extended component (AEM Text).
  • improved webpack component loader to better detect the resource type
    -moved some of the aem-core-components below jcr_root so that the resource type can be detected

How to test

  • build and run the aem-kitchensink-example
  • there should be a functional AEM Text story

Still TODO:

  • improve the way to determine the resource type
  • find a way to add multiple template roots to HTL engine

@tripodsan tripodsan requested a review from CodeByAlex April 2, 2020 02:42
@tripodsan tripodsan force-pushed the component-inheritance branch from b5a3966 to 8458464 Compare April 2, 2020 02:47
@tripodsan tripodsan force-pushed the component-inheritance branch from 8458464 to db56f50 Compare April 6, 2020 01:01
@tripodsan tripodsan requested a review from CodeByAlex April 6, 2020 01:01
CodeByAlex
CodeByAlex approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@CodeByAlex CodeByAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tripodsan
Copy link
Contributor Author

@CodeByAlex what is the problem with the failing tests ?

@CodeByAlex
Copy link
Member

LGTM

It does look like the build is failing though - could you check that it builds locally?

@CodeByAlex
Copy link
Member

@tripodsan it’s netlify checking that the build passed

@tripodsan tripodsan force-pushed the component-inheritance branch from db56f50 to ff74221 Compare April 6, 2020 02:21
@tripodsan tripodsan force-pushed the component-inheritance branch from ff74221 to 83f908d Compare April 6, 2020 03:33
@tripodsan tripodsan merged commit 05db8c1 into master Apr 6, 2020
@tripodsan tripodsan deleted the component-inheritance branch April 6, 2020 03:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CodeByAlex CodeByAlex CodeByAlex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tripodsan @CodeByAlex