Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use region-helper instead of hardcoded region functions #29

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

BibiSebi
Copy link
Contributor

@BibiSebi BibiSebi commented Jan 29, 2024

Issue:

What?

This PR includes using the new region-helper instead of hardcoded logic.

Why?

EXT-2122

How to test? (optional)

  1. run yarn build
  2. run yarn pack
  3. copy-paste the packed file (package.tgz) to your space/tool plugin
  4. adapt package.json to use the local dependency from the packed file (e.g.: @storyblok/app-extension-auth: "file:./../your-desintation/package.tgz")
  5. test the space/tool plugin in different regions (us)

@BibiSebi BibiSebi marked this pull request as ready for review January 30, 2024 15:36
@BibiSebi BibiSebi requested a review from eunjae-lee January 30, 2024 15:36
@BibiSebi
Copy link
Contributor Author

will this be a patch version update or a minor?

@demetriusfeijoo
Copy link
Contributor

will this be a patch version update or a minor?

Hey @BibiSebi, in my opinion, we may go with a minor here since this PR not only replaced the hardcoded we have with the region-helper but also enabled new regions.

What do you think? 🤔

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me ! 🎉

btw, this is a patch release.

minor release is only when you "add" a functionality.

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API

https://semver.org/

@BibiSebi
Copy link
Contributor Author

ok I will go with the minor then as it adds new functionality in sense of having the possibility to reach multiple new regions

@BibiSebi BibiSebi merged commit bad891f into main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants