-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter fix #339
base: main
Are you sure you want to change the base?
Linter fix #339
Conversation
Replaces occurences of 'catch (err)' with 'catch (err: any)'
Replaces occurences of 'catch (e)' with 'catch (e: any)'
Replaces occurences of 'catch(err)' with 'catch(err: any)'
Replaces let result; with let result:any
Replaces '--theme minimal' with '--theme default' in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to package-lock.json and package.json should be explained or removed. These files are very critical to maintain correctly. If you have tested the changes to these files to be working and advantageous please make another PR for them.
I see you did mention packages.json. it's just wild that it caused that many changes in the lock file. I will test this on windows, @Bus42 can you verify its working on linux? and I think @rmjuarez12 can verify mac? I forget are you on mac? |
I can verify that it works in Ubuntu. I did explain the change to package.json in the Loom, but I will update the PR text with the explanation as well. |
reverts change to 'gen-docs' script
I realized that the changes to package.json were due to errors when running |
b71b03e reverts the package files. I used this command that you might find useful! git restore --source main~7 package-lock.json |
I'm not going to be able to test this on windows until tomorrow. |
I've added explicit types to all instances with the exception of
These are proving a bit tricky |
I've addressed the typing in the remaining two files (oktaRequire.ts and utils.ts) by creating interfaces for both files and a constructor in oktaRequire.ts. Express functions still need explicit typing. They are currently all typed |
This should not have been touched as the error is unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hand testing passed on windows. Thank you @Bus42 !
Linting Errors Fix
Several linting errors are reported when running the backend locally. This PR addresses those errors by adding type definitions of
: any
: any
to functions flagged by the linterI only made the fixes necessary to address the linting errors
https://www.loom.com/share/d9f694621868415a9f58e4f7c8be8531
Changes to package.json and package.lock.json have been reverted since Loom recording