Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fixes that weren't merged during Labs #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

drew-ross
Copy link
Contributor

No description provided.

removed faker
Copy link
Contributor

@trevorjamesmartin trevorjamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • restrict dev-mode to a development branch,
  • remove the faker library from main,
  • create static data models, store them in JSON files, and use them as mock data.

I think it would behoove us to ask for DS approval on any PR that intersects with the DS API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants