Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: packages/utils upgrade to toucan-js@3.x #21

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Apr 5, 2023

Motivation:

Note

  • this narrows the type of opts.sentry to only be the subset of the Toucan type that is actually used

@@ -27,7 +27,6 @@
"noUnusedLocals": true,
"noUnusedParameters": false,
// advanced
"importsNotUsedAsValues": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because typescript warned about it as being deprecated

@gobengo gobengo requested review from travis and Gozala April 5, 2023 23:32
@gobengo gobengo changed the title feat!: packages/utils upgrade to toucan-js@3.x feat: packages/utils upgrade to toucan-js@3.x Apr 5, 2023
@gobengo gobengo merged commit e7a1b2a into master Apr 5, 2023
@gobengo gobengo deleted the 20-up-toucan branch April 5, 2023 23:45
Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants