fix: memory usage #1227
Merged
fix: memory usage #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
pushed a commit
that referenced
this pull request
Dec 7, 2023
🤖 I have created a release *beep* *boop* --- ## [12.3.2](upload-client-v12.3.1...upload-client-v12.3.2) (2023-12-07) ### Fixes * memory usage ([#1227](#1227)) ([c9e7a49](c9e7a49)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
to storacha/w3cli
that referenced
this pull request
Dec 7, 2023
Previously `parallel-transform-web` was running up to N transform tasks concurrently, but while those tasks were running it buffered the rest of the stream data internally 🤦 . This was resolved in alanshaw/parallel-transform-web#1 and then storacha/w3up#1227 so just pulling in the latest code here. I was seeing memory usage in w3cli for a 12GB file grow to ~10GB but now it stays at around at round ~4GB (which is the same usage I see when I remove `parallel-transform-web` and replace it with a regular serial `TransformStream`).
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
parallel-transform-webwas running up to N transform tasks concurrently, but while those tasks were running it buffered the rest of the stream data internally 🤦 .This was resolved in alanshaw/parallel-transform-web#1 so just pulling in the latest code here.
I was seeing memory usage in w3cli for a 12GB file grow to ~10GB but now it stays at around at round ~4GB (which is the same usage I see when I remove
parallel-transform-weband replace it with a regular serialTransformStream).