Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add size of the car constraint to store/add and impose it with presigned s3 URL #85

Closed
Gozala opened this issue Oct 3, 2022 · 4 comments
Closed

feat: add size of the car constraint to store/add and impose it with presigned s3 URL #85

Gozala opened this issue Oct 3, 2022 · 4 comments
Assignees
@ice-breaker-tg
Labels
PKey A key task or deliverable release/phase 1 topic/w3up-api
Milestone
w3up phase 1

Comments

@Gozala
Copy link
Contributor

Gozala commented Oct 3, 2022 •
edited
Loading

Let's try and demo the bad upload where client sets a wrong size but fails to upload because of s3 imposed size limit
@ice-breaker-tg
Copy link
Contributor

This is mostly setup here, and in web3-storage/sigv4.
Needs to be setup in w3up/client, but new access package needs to be released.

@alanshaw alanshaw added this to the w3up phase 1 milestone Nov 16, 2022
@alanshaw
Copy link
Member

alanshaw commented Nov 16, 2022 •
edited
Loading

@ice-breaker-tg can you port #266 to https://github.com/web3-storage/upload-api/blob/main/api/service/store/add.js#L50 please?

@alanshaw alanshaw mentioned this issue Nov 16, 2022
Closed
@alanshaw
Copy link
Member

alanshaw commented Dec 1, 2022

Needs review: storacha/sigv4#7

@alanshaw
Copy link
Member

Resolved in storacha/w3infra#66

gobengo pushed a commit that referenced this issue Mar 24, 2023
@dchoi27
feat: updated README instructions for MVP (#85)
0d0a038 
* feat: updated README instructions for MVP

* fix: mistakenly deleted a line

* feat: add placeholder for GH discussions

* feat: new ToS link

* fix: no beta in ToS URL

* feat: include updated ToS links

* feat: make README shippable

* feat: add provider optional parameter

---------

Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
gobengo pushed a commit that referenced this issue Apr 11, 2023
@dchoi27
feat: updated README instructions for MVP (#85)
e9db482 
* feat: updated README instructions for MVP

* fix: mistakenly deleted a line

* feat: add placeholder for GH discussions

* feat: new ToS link

* fix: no beta in ToS URL

* feat: include updated ToS links

* feat: make README shippable

* feat: add provider optional parameter

---------

Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ice-breaker-tg ice-breaker-tg

Labels
PKey A key task or deliverable release/phase 1 topic/w3up-api
Projects
None yet
Milestone
w3up phase 1
Development

No branches or pull requests
4 participants
@Gozala @alanshaw @heyjay44 @ice-breaker-tg