Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-please is suggesting too high of a version bump for w3up-client #694

Closed
gobengo opened this issue Mar 30, 2023 · 1 comment · Fixed by #695
Closed

release-please is suggesting too high of a version bump for w3up-client #694

gobengo opened this issue Mar 30, 2023 · 1 comment · Fixed by #695
Assignees
@travis @gobengo

Comments

@gobengo
Copy link
Contributor

gobengo commented Mar 30, 2023

Actual Behavior:

Expected Behavior:

  • it only suggests 5.x or maybe 6.x
@gobengo gobengo mentioned this issue Mar 30, 2023
Merged
gobengo added a commit that referenced this issue Mar 30, 2023
@gobengo
ci: release-please-config sets bootstrap sha (#695)
24d92f6 
Motivation:
* try to fix #694
@gobengo gobengo mentioned this issue Mar 30, 2023
Merged
gobengo added a commit that referenced this issue Mar 30, 2023
@gobengo
fix: add newline to space.js to test release-please 694 fix (#696)
ea18619 
Motivation:
* dummy commit to test #694 
* I expect when we merge this, I want to see release-please open a
w3up-client release-please PR for 5.5.1
@gobengo
Copy link
Contributor Author

gobengo commented Mar 30, 2023

I believe this happened because release-please was confused after I renamed the repo from w3protocol to w3up.

What I did to resolve:

gobengo added a commit that referenced this issue Apr 11, 2023
@gobengo
ci: release-please-config sets bootstrap sha (#695)
56eead0 
Motivation:
* try to fix #694
gobengo added a commit that referenced this issue Apr 11, 2023
@gobengo
fix: add newline to space.js to test release-please 694 fix (#696)
6bc4dc3 
Motivation:
* dummy commit to test #694 
* I expect when we merge this, I want to see release-please open a
w3up-client release-please PR for 5.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis travis

@gobengo gobengo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: release-please-config sets bootstrap sha storacha/w3up
2 participants
@travis @gobengo