Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid UCAN chains seem to get authorized #179

Closed
Gozala opened this issue Nov 17, 2022 · 2 comments
Closed

Invalid UCAN chains seem to get authorized #179

Gozala opened this issue Nov 17, 2022 · 2 comments
Assignees
@Gozala
Milestone
w3up phase 1

Comments

@Gozala
Copy link
Contributor

Gozala commented Nov 17, 2022

As per this long thread https://github.com/web3-storage/w3protocol/pull/148/files#r1024259741 we seem to have tests that create invalid UCAN chains, yet get somehow authorized instead of causing erros

https://github.com/web3-storage/w3protocol/blob/2923aceb7e5dfb1f12b42b8caf9c2f4416238650/packages/upload-client/test/index.test.js#L29-L42
@Gozala Gozala self-assigned this Nov 17, 2022
@Gozala Gozala added this to the w3up phase 1 milestone Nov 17, 2022
@Gozala
Copy link
Contributor Author

Gozala commented Nov 17, 2022

Looks like proofs are not even included in upload requests

https://github.com/web3-storage/w3protocol/blob/2923aceb7e5dfb1f12b42b8caf9c2f4416238650/packages/upload-client/src/upload.js#L33-L41

@alanshaw
Copy link
Member

This was fixed :) https://github.com/web3-storage/w3protocol/blob/main/packages/upload-client/src/upload.js#L45

fforbeck pushed a commit to storacha/upload-service that referenced this issue Feb 5, 2025
@github-actions
chore(main): release w3console 1.17.3 (storacha#179)
7c1948e 
🤖 I have created a release *beep* *boop*
---


##
[1.17.3](storacha/console@w3console-v1.17.2...w3console-v1.17.3)
(2025-01-09)


### Bug Fixes

* cors preflight issue in production
([storacha#178](storacha/console#178))
([1b1b79a](storacha/console@1b1b79a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gozala Gozala

Labels
None yet
Projects
None yet
Milestone
w3up phase 1
Development

No branches or pull requests
2 participants
@Gozala @alanshaw