-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update vanilla sign-up example #129
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b9e42c6:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - not entirely sure we should check in the staging service details, and if so probably nice to stash them somewhere we can use them in all examples, but not sure exactly where
this.identity = identity | ||
this.email = identity.email | ||
const agent = await this.getAgent() | ||
console.log(`Agent DID: ${agent.did()}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably remove this line
console.log(`Agent DID: ${agent.did()}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see we're logging other things, looks like intentionally, so maybe ignore this?
This just updates the vanilla sign up/in example to use the new stuff from #119.
I've got the file upload example nearly done as well, but need to wrap things up for the day, so I'll finish it tomorrow.
@alanshaw this PR is targeting the branch from #119, so feel free to pull it in there if you want. Otherwise I'll retarget this one after that one merges.