Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vanilla sign-up example #129

Merged
merged 21 commits into from
Dec 2, 2022

Conversation

yusefnapora
Copy link
Contributor

This just updates the vanilla sign up/in example to use the new stuff from #119.

I've got the file upload example nearly done as well, but need to wrap things up for the day, so I'll finish it tomorrow.

@alanshaw this PR is targeting the branch from #119, so feel free to pull it in there if you want. Otherwise I'll retarget this one after that one merges.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9e42c6:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

@heyjay44 heyjay44 mentioned this pull request Nov 29, 2022
51 tasks
Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - not entirely sure we should check in the staging service details, and if so probably nice to stash them somewhere we can use them in all examples, but not sure exactly where

this.identity = identity
this.email = identity.email
const agent = await this.getAgent()
console.log(`Agent DID: ${agent.did()}`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably remove this line

Suggested change
console.log(`Agent DID: ${agent.did()}`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see we're logging other things, looks like intentionally, so maybe ignore this?

Base automatically changed from feat/integrate-new-ucanto to next December 2, 2022 15:14
@alanshaw alanshaw merged commit 012a565 into next Dec 2, 2022
@alanshaw alanshaw deleted the feat/integrate-new-ucanto-vanilla-examples branch December 2, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants